Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Display custom logo as plain text #10350

Merged
merged 4 commits into from
Jul 12, 2024
Merged

[5.x] Display custom logo as plain text #10350

merged 4 commits into from
Jul 12, 2024

Conversation

daun
Copy link
Contributor

@daun daun commented Jun 21, 2024 •
edited by jasonvarga
Loading

Description

Add an option to display the site's name in plain text in the control panel, as suggested in feature idea #1185.

Advantages of doing that

  • Consumes less bandwidth than a logo file
  • Light/dark mode comes along for free
  • Less setup for new projects: just paste in the name

Details

  • When defined, logo image urls take precedence over logo text
  • The logo text goes into a new statamic.cp.custom_logo_text config key
  • Can also be set from a new STATAMIC_CUSTOM_LOGO_TEXT environment variable
  • I guess this can be backported to 4.x without problems
  • As far as I can tell, there's currently no tests for the custom logo behavior, so I haven't added any
  • Manually tested, though :)

Screenshots

Screenshot 2024-06-21 at 13 09 51   Screenshot 2024-06-21 at 13 10 11   Screenshot 2024-06-21 at 13 08 09   Screenshot 2024-06-21 at 13 08 28

Closes statamic/ideas#1185

@daun daun changed the title Display custom logo as plain text [5.x] Display custom logo as plain text Jun 21, 2024
@daun daun mentioned this pull request Jun 21, 2024
Open
@jasonvarga jasonvarga merged commit 9b3ff54 into statamic:5.x Jul 12, 2024
18 of 19 checks passed
@duncanmcclean duncanmcclean mentioned this pull request Jul 18, 2024
Closed
duncanmcclean added a commit to statamic/statamic that referenced this pull request Aug 7, 2024
@duncanmcclean
Display custom logo as plain text
3e96a4e 
Related: statamic/cms#10350
duncanmcclean added a commit to statamic/statamic that referenced this pull request Aug 7, 2024
@duncanmcclean
Sync Statamic configs (#80)
2d0cbf6 
* Allow configuring the Stache's Cache Store

Related: statamic/cms#10303

* Ability to disable CP authentication

Related: statamic/cms#8960

* Display custom logo as plain text

Related: statamic/cms#10350

* Track sites.yaml path in git integration config

Related: statamic/cms#10463

* Add ability to specify the queue connection on static:warm command

Related: statamic/cms#8634
@jacksleight jacksleight mentioned this pull request Oct 9, 2024
Closed
@daun daun deleted the feature/custom-logo-text branch October 21, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display custom control panel logo as plain text instead of an image file
2 participants
@daun @jasonvarga