[5.x] Use form submission query count instead of collection count

[dnwjn]

Hello everyone!

We stumbled upon a bug on /admin/forms. We would get endless loading screens and eventually timeouts when visiting this page. We have quiet an amount of form submissions (~150.000), and the controller in the current setup retrieves all submissions, loads them in memory, to then return a count.

We're using Statamic 5 with the statamic/eloquent-driver implementation, and in that package it would retrieve the model for the submission, and then the model for the form. But it would do that for every submission. First we changed something there, but then realized a simple fix for this would be in the FormsController instead.

If you have any questions or comments about this, let me know!

[ryanmitchell]

Nice. You'll need to update your PR title to [5.x] Use query count instead of collection count to pass the PR title check

[dnwjn]

Nice. You'll need to update your PR title to [5.x] Use query count instead of collection count to pass the PR title check

Gotcha, wasn't sure if it was something I had to do, or the team would do. It's changed!