Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for MS v1.0, Statamic 4.0 and Laravel 10 #13

Merged
merged 10 commits into from
May 29, 2023

Conversation

lakkes-ra
Copy link
Contributor

Hi there!

We've made some changes to the Statamic MeiliSearch driver to ensure compatibility with MeiliSearch v1.0. One minor issue we encountered was that an empty array could no longer be passed as settings. We've carefully reviewed the breaking changes in the meilisearch-php package, but couldn't find any more code in your driver that needed to be updated.

Our testing was limited to a small application, so there may be issues that we haven't yet encountered. If you have a larger application where you can test the driver, we'd greatly appreciate your feedback.

While changing the settings behavior may not be a major update, we also bumped the meilisearch-php version to ensure we're not using an outdated version.

We hope that this will be of help and are happy to receive feedback.

@lakkes-ra lakkes-ra changed the title Update for MeiliSearch Version 1 Update for MeiliSearch v1.0 Mar 20, 2023
@brunoocasali
Copy link

Hi @lakkes-ra, I think you can also remove part of the disclaimer in the README:

Disclaimer: This search driver is used on a large production site, however MeiliSearch is still changing often, so some problems may occur. Please submit any bugs you find so we can make the driver more stable. If you would like to help maintain the driver, please reach out.

Meilisearch is now v1 and also the main dependency of this package meilisearch-php :)

@lakkes-ra
Copy link
Contributor Author

Hi @brunoocasali, done. 👍
@okaufmann are you still maintaining this package?

@lakkes-ra
Copy link
Contributor Author

In the meantime we did further changes to our fork. We use it in a (currently in development) project with Statamic v4 and Laravel v10 now. Still works fine. We also removed some of the backwarts compatibilites.

@lakkes-ra lakkes-ra changed the title Update for MeiliSearch v1.0 Update for MS v1.0, Statamic 4.0 and Laravel 10 May 10, 2023
@okaufmann okaufmann merged commit a633f67 into statamic-rad-pack:main May 29, 2023
@goellner
Copy link

could you tag a release with this changes?

@okaufmann
Copy link
Collaborator

done

@lakkes-ra
Copy link
Contributor Author

I just noticed that the data on the Statamic Addon page is not up to date yet.
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants