Add UI for Markers with end seconds on scene player. #5633
+432
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please include a proper description for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End seconds to markers was added in #5311. However, the UI has not yet had a way to show markers that are timespans instead of single timestamps. This PR adds support to show markers that are a timerange/timespan. To be able to see multiple markers that would have overlapping time ranges, time ranges stack when needed. Tags used for primary tags of markers are each assigned a unique/consistent (when possible) color so that users can easily distinguish the different markers. Also existing behavior with tag name on hover popping up is maintained.