Update KeyboardShortcuts.md #5615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added table of shortcuts for Image page - Reorganized a few tables to include sub-headings - Renamed `Edit Scene tab [...]` heading to `Scene Edit tab [...]` for logical consistency with other headings - Moved Scene page rating shortcuts from vestigial location in *Edit Scene* section to global Scene page section
DogmaDragon
reviewed
Jan 20, 2025
Comment on lines
+147
to
+150
| | Ratings || | ||
| | `r {1-5}` | [Edit mode] Set rating (stars) | | ||
| | `r 0` | [Edit mode] Unset rating (stars) | | ||
| | `r {0-9} {0-9}` | [Edit mode] Set rating (decimal - `r 0 0` for `10.0`) | |
There was a problem hiding this comment.
I would like to move this section (including line 144) under a new header Edit Groups tab shortcuts and stripping [Edit mode] from the action name.
There is a technical issue where the only way to trigger rating shortcuts is by entering edit mode or rating something manually, after that they will work outside edit mode too.
But I noticed some other inconsistent behavior with some other shortcuts, so it probably needs more in-depth review at some point, I'll approve the PR without this change.
DogmaDragon
approved these changes
Feb 14, 2025
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Mar 27, 2025
* Update KeyboardShortcuts.md - Added table of shortcuts for Image page - Reorganized a few tables to include sub-headings - Renamed `Edit Scene tab [...]` heading to `Scene Edit tab [...]` for logical consistency with other headings - Moved Scene page rating shortcuts from vestigial location in *Edit Scene* section to global Scene page section * Update edit header to be consitant with the others --------- Co-authored-by: DogmaDragon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit Scene tab [...]heading toScene Edit tab [...]for logical consistency with other headings