Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme edits #4

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Readme edits #4

wants to merge 9 commits into from

Conversation

kelseiv
Copy link

@kelseiv kelseiv commented Apr 16, 2024 •
edited
Loading

my first push up worked, but see after i got the movies table config error, that may be breaking the build

kelseiv
kelseiv commented Apr 16, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
kelseiv
kelseiv commented Apr 17, 2024
View reviewed changes
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
hdulay
hdulay reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@hdulay hdulay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to add a loop to check for all tables before starting the ingestion job.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@gAmUssA gAmUssA mentioned this pull request Apr 17, 2024
Merged
gAmUssA
gAmUssA suggested changes Apr 17, 2024
View reviewed changes
table/ratings.schema.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdulay hdulay hdulay left review comments

@gAmUssA gAmUssA gAmUssA requested changes

@matthewhelmke matthewhelmke Awaiting requested review from matthewhelmke

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelseiv @gAmUssA @hdulay