Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use the regualr dependnacies to import the install the starknet-sierra-compile crate #728

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Sep 8, 2024

This change is Reviewable

@ArniStarkware ArniStarkware marked this pull request as ready for review September 8, 2024 09:28
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@ArniStarkware ArniStarkware force-pushed the arni/starknet_sierra_compile/use_toml_to_import_specific_version branch from 7305cce to 5409af6 Compare September 8, 2024 09:44
Copy link

github-actions bot commented Sep 8, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.638 ms 65.717 ms 65.811 ms]
change: [-9.8202% -5.9209% -2.3869%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severe

@ArniStarkware ArniStarkware force-pushed the arni/starknet_sierra_compile/use_toml_to_import_specific_version branch 2 times, most recently from ee93161 to 35c85f6 Compare September 8, 2024 11:05
@ArniStarkware ArniStarkware force-pushed the arni/starknet_sierra_compile/use_toml_to_import_specific_version branch from 35c85f6 to 0198d1a Compare September 8, 2024 11:21
@ArniStarkware
Copy link
Contributor Author

crates/starknet_sierra_compile/Cargo.toml line 18 at r3 (raw file):

serde.workspace = true
serde_json.workspace = true
starknet-sierra-compile = { package = "starknet-sierra-compile", version = "2.7.0", artifact = "bin"}

The feature of adding artifact = to the dependency is unstable:
I could run it with: rustup run nightly cargo test -Z bindeps.

I have not figured out yet how to set the version independently of other dependencies.
Read more about the unstable feature of artifact-dependencies: open_issue, documentation

Code quote:

starknet-sierra-compile = { package = "starknet-sierra-compile", version = "2.7.0", artifact = "bin"}

Copy link

github-actions bot commented Oct 9, 2024

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 9, 2024
@github-actions github-actions bot closed this Oct 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant