Refactor syntax-gen.

[orizi]

Stack:

• Made signed int add and sub more efficient. #6465
• Refactor syntax-gen. #6464 ⬅
• Remove unneeded allows - or make them expect instead. #6461
• Made hash of substition not allocation memory. #6460
• Added analyzer check for enums with starknet::Store with no default. #6459

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[ilyalesokhin-starkware]

crates/cairo-lang-syntax-codegen/src/generator.rs line 117 at r1 (raw file):

}

fn name_tokens<'a, 'b>(

Do you need different lifetimes?

Code quote:

'a, 'b

[ilyalesokhin-starkware]

crates/cairo-lang-syntax-codegen/src/generator.rs line 119 at r1 (raw file):

fn name_tokens<'a, 'b>(
    spec: &'a [Node],
    predicate: impl Fn(&NodeKind) -> bool,

document the purpose of the predicate?

Code quote:

    predicate: impl Fn(&NodeKind) -> bool,

[ilyalesokhin-starkware]

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @orizi)

[orizi]

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @ilyalesokhin-starkware)

---

crates/cairo-lang-syntax-codegen/src/generator.rs line 117 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

Do you need different lifetimes?

Done.

---

crates/cairo-lang-syntax-codegen/src/generator.rs line 119 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

document the purpose of the predicate?

Done.