fix(security)!: avoid DoS on malicious insert to memory#1099
Merged
Conversation
0ec72db to
99e9e0a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1099 +/- ##
=======================================
Coverage 98.15% 98.15%
=======================================
Files 85 85
Lines 34534 34553 +19
=======================================
+ Hits 33897 33916 +19
Misses 637 637
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
99e9e0a to
0116d04
Compare
|
Benchmark Results for unmodified programs 🚀
|
pefontana
approved these changes
May 4, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
…bs#1099) Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids
panics on allocation failure and integer overflow during calls toMemory::insert.Fixes #798
Closes #805
Checklist