Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Add out of gas test. #593

Merged
merged 1 commit into from
Jun 11, 2023
Merged

Add out of gas test. #593

merged 1 commit into from
Jun 11, 2023

Conversation

noaov1
Copy link
Collaborator

@noaov1 noaov1 commented Jun 11, 2023

This change is Reviewable

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase and @noaov1)


crates/blockifier/src/execution/syscalls/syscalls_test.rs line 498 at r1 (raw file):

    };
    let error = entry_point_call.execute_directly(&mut state).unwrap_err();
    assert_matches!(error,EntryPointExecutionError::ExecutionFailed{ error_data}

Fix your formatter?
@giladchase, how come rustfmt didn't catch this?

Suggestion:

assert_matches!(error, EntryPointExecutionError::ExecutionFailed{ error_data }

Copy link
Collaborator

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul)


crates/blockifier/src/execution/syscalls/syscalls_test.rs line 498 at r1 (raw file):

Previously, elintul (Elin) wrote…

Fix your formatter?
@giladchase, how come rustfmt didn't catch this?

rustfmt doesn't support macros.

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase)


crates/blockifier/src/execution/syscalls/syscalls_test.rs line 498 at r1 (raw file):

Previously, giladchase wrote…

rustfmt doesn't support macros.

I think we had this outside macros too...

Copy link
Collaborator Author

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul)


crates/blockifier/src/execution/syscalls/syscalls_test.rs line 498 at r1 (raw file):

Previously, elintul (Elin) wrote…

I think we had this outside macros too...

Done.

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase)


crates/blockifier/src/execution/syscalls/syscalls_test.rs line 498 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Done.

Fixed the formatter?

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

@noaov1 noaov1 merged commit 2381193 into main-v0.12.0 Jun 11, 2023
@noaov1 noaov1 deleted the noa/add_out_of_gas_test branch June 11, 2023 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants