-
Notifications
You must be signed in to change notification settings - Fork 107
Conversation
bdd30a1
to
d4e5269
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase and @noaov1)
crates/blockifier/src/execution/syscalls/syscalls_test.rs
line 498 at r1 (raw file):
}; let error = entry_point_call.execute_directly(&mut state).unwrap_err(); assert_matches!(error,EntryPointExecutionError::ExecutionFailed{ error_data}
Fix your formatter?
@giladchase, how come rustfmt
didn't catch this?
Suggestion:
assert_matches!(error, EntryPointExecutionError::ExecutionFailed{ error_data }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul)
crates/blockifier/src/execution/syscalls/syscalls_test.rs
line 498 at r1 (raw file):
Previously, elintul (Elin) wrote…
Fix your formatter?
@giladchase, how comerustfmt
didn't catch this?
rustfmt
doesn't support macros.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase)
crates/blockifier/src/execution/syscalls/syscalls_test.rs
line 498 at r1 (raw file):
Previously, giladchase wrote…
rustfmt
doesn't support macros.
I think we had this outside macros too...
d4e5269
to
78ba024
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @elintul)
crates/blockifier/src/execution/syscalls/syscalls_test.rs
line 498 at r1 (raw file):
Previously, elintul (Elin) wrote…
I think we had this outside macros too...
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase)
crates/blockifier/src/execution/syscalls/syscalls_test.rs
line 498 at r1 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Done.
Fixed the formatter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)
This change is