CQLSessionCache - evictionListener changed to removalListener #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathirsvn
changed the title
|
@stargate/core The IT for the native image fails in this PR. I reported the same here. Can we disable native image test for now until this is fixed on the Quarkus side? |
Yes, I agree this makes sense @kathirsvn |
|
Excluded the Native Image CI tests and the tests look good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In
CQLSessionCache, Caffeine cache'sevictionListeneris changed toremovalListener.CqlSessionthat is passed which is a graceful shut down (i.e. any in-flight queries will be completed before shutting down the channels)Which issue(s) this PR fixes:
Fixes #645
Checklist