bump python client version to enable better URL handling#257
Closed
dataders wants to merge 1 commit intostarburstdata:masterfrom
Closed
bump python client version to enable better URL handling#257dataders wants to merge 1 commit intostarburstdata:masterfrom
dataders wants to merge 1 commit intostarburstdata:masterfrom
Conversation
dataders
commented
Mar 3, 2023
| install_requires=[ | ||
| "dbt-core~={}".format(dbt_version), | ||
| "trino==0.321.0", | ||
| "trino==0.322.0", |
Contributor
Author
There was a problem hiding this comment.
@mdesmet, should this be the following instead? relatedly, i'm interested to know if a 1.0 milestone for the client if coming anytime soon
Suggested change
| "trino==0.322.0", | |
| "trino>=0.321.0<1.0.0", |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
resolves: #245
Now that trinodb/trino-python-client#340 is merged and released in version 0.322 of the Python client (thanks @mdesmet!) this will enable a much-better end user experience for users of Trino and dbt.
Checklist
README.mdupdated and added information about my changechangie newto create a changelog entry