Skip to content

Use views for the creating the temporary models in Delta tests#205

Merged
mdesmet merged 2 commits intomasterfrom
findinpath/delta_views_enabled
Jan 4, 2023
Merged

Use views for the creating the temporary models in Delta tests#205
mdesmet merged 2 commits intomasterfrom
findinpath/delta_views_enabled

Conversation

@findinpath
Copy link
Copy Markdown
Collaborator

Overview

Now that there can be used Trino views in Delta Lake connector - see trinodb/trino#11763 - there is no need to set views_enabled to false for the temporary models in the tests.

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • README.md updated and added information about my change
  • I have run changie new to create a changelog entry

@github-actions
Copy link
Copy Markdown

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mdesmet
Copy link
Copy Markdown
Contributor

mdesmet commented Jan 2, 2023

I think this should be announced as a breaking change as it requires to upgrade to latest Trino version.

@findinpath
Copy link
Copy Markdown
Collaborator Author

I think this should be announced as a breaking change as it requires to upgrade to latest Trino version.

This change affects only the tests - no productive code has been changed.

@mdesmet mdesmet merged commit 1e199ae into master Jan 4, 2023
@mdesmet mdesmet deleted the findinpath/delta_views_enabled branch January 4, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants