Skip to content

Fix ParallelExecutor crash when Parallel called from within module forward() #9104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LukeDevs wants to merge 3 commits into
base: main
Choose a base branch
from
+77 −0
Open

Fix ParallelExecutor crash when Parallel called from within module forward() #9104

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12d5987
Fix incorrect ContextVar access in ParallelExecutor and add error log…
Dec 1, 2025
d820973
Implemented feedback and added unit test.
Dec 14, 2025
8eb6e38
Merge branch 'main' into BUG-FIX/parallelizer-contextvar-and-error-lo…
LukeDevs Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions dspy/utils/parallelizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,10 @@ def worker(parent_overrides, submission_id, index, item):
from dspy.dsp.utils.settings import thread_local_overrides

original = thread_local_overrides.get()
token = thread_local_overrides.set({**original, **parent_overrides.copy()})
new_overrides = {**original, **parent_overrides.copy()}
if parent_overrides.get("usage_tracker"):
# Usage tracker needs to be deep copied across threads so that each thread tracks its own usage
thread_local_overrides.overrides["usage_tracker"] = copy.deepcopy(parent_overrides["usage_tracker"])
new_overrides["usage_tracker"] = copy.deepcopy(parent_overrides["usage_tracker"])
Copy link
Collaborator

@TomeHirata TomeHirata Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, can we keep the comment? And also can you add a test?

Copy link
Author

@LukeDevs LukeDevs Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomeHirata Added the comment back in directly above the deep copy.

token = thread_local_overrides.set(new_overrides)

try:
return index, function(item)
Expand Down Expand Up @@ -154,7 +154,9 @@ def all_done():
try:
index, outcome = f.result()
except Exception:
pass
logger.error(f"Worker failed: {e}")
Copy link
Collaborator

@TomeHirata TomeHirata Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really helpful since we catch exceptions by wrapping the original function in _wrap_function

Copy link
Author

@LukeDevs LukeDevs Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomeHirata Understood. I've reverted back to pass.

if self.provide_traceback:
traceback.print_exc()
else:
if outcome != job_cancelled and results[index] is None:
# Check if this is an exception
Expand Down