Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move APIs to Promise #249

Closed
theoludwig opened this issue Aug 16, 2021 · 1 comment · Fixed by #270
Closed

Move APIs to Promise #249

theoludwig opened this issue Aug 16, 2021 · 1 comment · Fixed by #270
Labels
enhancement
Milestone
15.0.0

Comments

@theoludwig
Copy link
Contributor

Instead of having sync or callback versions of our APIs, we could migrate them to Promises.
By doing this, it makes #234 simpler to solve, as the "new" ESLint class API use Promises.

We will remove Linter.lintTextSync method.

Note: It is a BREAKING CHANGE
@theoludwig theoludwig added this to the 15.0.0 milestone Aug 16, 2021
@theoludwig theoludwig mentioned this issue Aug 16, 2021
Merged
2 tasks
@voxpelli
Copy link
Member

voxpelli commented Aug 16, 2021 •
edited
Loading

An extra, probably needless, clarification: We will probably mainly do this through async / await rather than creating Promises directly ourselves 👍

@theoludwig theoludwig mentioned this issue Aug 17, 2021
Closed
4 tasks
voxpelli added a commit that referenced this issue Oct 3, 2021
@voxpelli
BREAKING: Make Promise based
4207670 
Fixes #249

Changes the callback based API:s to instead be async and return Promises. Also removes the sync versions of the API:s, to allow for eg. async `resolveEslintConfig`
voxpelli added a commit that referenced this issue Oct 3, 2021
@voxpelli
BREAKING: Make Promise based
b736589 
Fixes #249

Changes the callback based API:s to instead be async and return Promises.
@voxpelli voxpelli mentioned this issue Oct 3, 2021
Merged
voxpelli added a commit that referenced this issue Oct 3, 2021
@voxpelli
BREAKING: Make Promise based
7f15fba 
Fixes #249

Changes the callback based API:s to instead be async and return Promises.
@theoludwig theoludwig mentioned this issue Oct 7, 2021
Merged
voxpelli added a commit that referenced this issue Oct 14, 2021
@voxpelli
chore: move APIs to async/await (+ fix tests failing) (#270)
d13ac93 
* Add editorconfig

* BREAKING: Make Promise based

Fixes #249

Changes the callback based API:s to instead be async and return Promises.

* Keep cli() not returning a promise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
The Standard Project
Archived in project
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

Move APIs to async/await (+ fix tests failing due to ESM-based standard) standard/standard-engine
2 participants
@voxpelli @theoludwig