Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix es2020 globals not being recognized #156

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Conversation

faridnsh
Copy link
Contributor

Fixes standard/standard#1436

The ecmaVersion in parserOptions is only for setting syntax support.

From the docs: https://eslint.org/docs/user-guide/configuring

supporting ES6 syntax is not the same as supporting new ES6 globals

Setting the es2020 env will actually set the globals:

adds all ECMAScript 2020 globals and automatically sets the ecmaVersion parser option to 11.

Fixes standard/standard#1436

The ecmaVersion in parserOptions is only for setting syntax support.

From the docs: https://eslint.org/docs/user-guide/configuring

> supporting ES6 syntax is not the same as supporting new ES6 globals

Setting the es2020 env will actually set the globals:

> adds all ECMAScript 2020 globals and automatically sets the ecmaVersion parser option to 11.
@amclin
Copy link

amclin commented Dec 6, 2019

If this is approved, what does it take to get merged and released?

@mightyiam
Copy link
Member

@amclin it would likely take @feross pressing the big green button.

@Saiv46
Copy link

Saiv46 commented Feb 25, 2020

Any progress?

@dlqqq
Copy link

dlqqq commented Aug 11, 2020

i'm assuming this PR will only be merged upon the v15.0.0 release?

@feross feross merged commit d6fd464 into standard:master Oct 21, 2020
@feross
Copy link
Member

feross commented Oct 21, 2020

This will be part of standard v15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

'BigInt' is not defined.
8 participants