Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support ESLint 8.x #41

Merged
merged 3 commits into from
Jan 31, 2022
Merged

feat: support ESLint 8.x #41

merged 3 commits into from
Jan 31, 2022

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Oct 10, 2021 •
edited
Loading

ESLint v8.0.0 is released 🎉

Dependencies should be compatible with ESLint 8 too before we can merge this one:

Closes #40

@welcome
Copy link

welcome bot commented Oct 10, 2021

🙌 Thanks for opening this pull request! You're awesome.

@MichaelDeBoey MichaelDeBoey mentioned this pull request Oct 10, 2021
Merged
26 tasks
LinusU
LinusU reviewed Oct 11, 2021
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey marked this pull request as draft October 11, 2021 10:19
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review October 11, 2021 10:29
LinusU
LinusU reviewed Oct 11, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
voxpelli
voxpelli requested changes Oct 14, 2021
View reviewed changes
Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help! 🙏

Would have been great though to get the Travis to GitHub CI as a separate PR to get them all smaller and easier to review and merge – getting the PR:s as atomic as possible.

The changes to the tests looks good, I added some comments around the rest 🙂

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.github/workflows/validate.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.gitattributes Outdated Show resolved Hide resolved
@theoludwig
Copy link
Member

Hey, @MichaelDeBoey!
Thanks for your PR, could you address the comments so we can merge this quickly. 😄

theoludwig
theoludwig approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@theoludwig theoludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

LinusU
LinusU approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think that we should remove package-lock.json and yarn.lock from .gitignore

What do we think about also removing package-lock.json and yarn.lock from the gitignore? So that one notices if a lock file is erroneously being used?

Otherwise it looks great 👍 🎉

@theoludwig
Copy link
Member

Friendly ping @voxpelli to review this, and if good, release a new prerelease version. 😄

@voxpelli
Copy link
Member

Friendly ping @voxpelli to review this, and if good, release a new prerelease version. 😄

🙏 I'll see if I can get to it today or tomorrow 👍

voxpelli
voxpelli approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some syncing up with the 17.0.0-0 of eslint-config-standard.

We should eventually sync the GH Actions as well + possibly dependabot, but for now this is good enough. I'll merge and will release a prerelease of this one as well.

.github/workflows/validate.yml
@@ -0,0 +1,39 @@
name: validate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like some of the things in this GH Action. I do think that we really should set up reusable GH Actions though, as there are no reasons whatsoever for this one to differ from https://github.com/standard/eslint-config-standard/blob/cade6a519f595c17d135408872dccf1f3767840a/.github/workflows/ci.yml

.gitignore Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@voxpelli voxpelli merged commit b919947 into standard:master Jan 31, 2022
@welcome
Copy link

welcome bot commented Jan 31, 2022

🎉 Congrats on getting your first pull request landed!

@MichaelDeBoey MichaelDeBoey deleted the eslint-8 branch January 31, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theoludwig theoludwig theoludwig approved these changes

@midudev midudev midudev approved these changes

@LinusU LinusU LinusU approved these changes

@voxpelli voxpelli voxpelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
The Standard Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ESLint 8.x
5 participants
@MichaelDeBoey @theoludwig @voxpelli @LinusU @midudev