Make Topic a newtype #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnarubin
reviewed
Mar 17, 2021
src/topic.rs
Outdated
| @@ -0,0 +1,21 @@ | |||
| /// A message queue topic name to which messages can be published | |||
| #[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash, Default)] | |||
| pub struct Topic(pub &'static str); | |||
There was a problem hiding this comment.
I think it should be a Cow<'static, str> while we're at it. Topic choice could be dynamic
There was a problem hiding this comment.
IIRC @maroux was against the idea of there being topics that can differ based on message contents, but I'll let them to chime in.
There was a problem hiding this comment.
I made the field private which should make it possible to extend this to Cow in a backwards compatible manner in the future.
Turns out having anything with any sort of lifetime in stream/sink chains will trigger nasty issues such as rust-lang/rust#79648 which is pretty difficult to figure out how to work around. Making `Topic` a newtype erases the lifetime from the type, making it significantly easier to work with in thsoe contexts.
rnarubin
approved these changes
Mar 18, 2021
rnarubin
pushed a commit
to rnarubin/hedwig-rust
that referenced
this pull request
Mar 29, 2021
Turns out having anything with any sort of lifetime in stream/sink chains will trigger nasty issues such as rust-lang/rust#79648 which is pretty difficult to figure out how to work around. Making `Topic` a newtype erases the lifetime from the type, making it significantly easier to work with in thsoe contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out having anything with any sort of lifetime in stream/sink
chains will trigger nasty issues such as
rust-lang/rust#79648 which is pretty difficult
to figure out how to work around.
Making
Topica newtype erases the lifetime from the type, making itsignificantly easier to work with in thsoe contexts.