acme: Don't restrict challenge types#1522
Merged
Merged
Conversation
When testing my Stalwart deployment with Pebble[1], I got the following
ACME error:
ACME error (acme.error) {
reason = "unknown variant `dns-account-01`, expected one of `http-01`, `dns-01`, `tls-alpn-01` at line 15 column 33",
details = JSON deserialization failed
}
In RFC 8555 section 8[2], the validation challenges are meant to be
extensible:
> The identifier validation challenges described in this section all
> relate to validation of domain names. If ACME is extended in the
> future to support other types of identifiers, there will need to be
> new challenge types, and they will need to specify which types of
> identifier they apply to.
The mentioned error refers to the following draft:
https://datatracker.ietf.org/doc/html/draft-ietf-acme-dns-account-label-01
Pebble already implemented[3] this and while it's IMHO too early to
already support this in Stalwart, we should at least make sure that we
don't break existing deployments in case ACME CAs one day add more
challange types like the above.
[1]: https://github.com/letsencrypt/pebble
[2]: https://datatracker.ietf.org/doc/html/rfc8555#section-8
[3]: letsencrypt/pebble#435
Signed-off-by: aszlig <aszlig@nix.build>
|
|
Member
|
Thanks, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing my Stalwart deployment with Pebble1, I got the following ACME error:
In RFC 8555 section 82, the validation challenges are meant to be extensible:
The mentioned error refers to the following draft:
https://datatracker.ietf.org/doc/html/draft-ietf-acme-dns-account-label-01
Pebble already implemented3 this and while it's IMHO too early to already support this in Stalwart, we should at least make sure that we don't break existing deployments in case ACME CAs one day add more challange types like the above.