Fix clickhouse ports and passwords in helpers #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clickhouse needs port 8123 (HTTP) for console and rotor, but needs port 9000 (TCP) for bulker and ingest. See the [docker-compose.yaml](https://github.com/jitsucom/jitsu/blob/newjitsu/docker/docker-compose.yml). * Clean up newlines that were creating username and passwords like "\njitsu".
|
Good catch. Regarding the port issue, I think a decent solution without shifting things around too much is to provide separate parameters for the HTTP/TCP hosts on a global level while retaining the current behavior on a per-service basis. I'll open a PR to your branch since I already made an implementation for it while looking into this. Let me know what you think. |
feat: break out clickhouse host into http and tcp in global config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickhouse needs port 8123 (HTTP) for console and rotor, but needs port 9000 (TCP) for bulker and ingest. See the
docker-compose.yaml.
Clean up newlines that were creating username and passwords like "\njitsu".
I am not sure this is the cleanest way to handle the port issue. Another option would be to break out the clickhouse port and have differing defaults by service.