Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Osrm to route builder for custom route adapters #176

Merged
merged 9 commits into from
Aug 13, 2024

Conversation

Archdoog
Copy link
Collaborator

@Archdoog Archdoog commented Aug 6, 2024

  • Adds method to createRouteFromOsrm to simplify import for custom route adapters that use OSRM (e.g. valhalla-mobile)
  • Revises OsrmResponseParser to use new route creation method. Note: this architecture bundles the via_waypoints and waypoints into each Route init. While this is technically extra work, I figured it was the lesser cost of duplicating and creating extra function entry points for pre-built waypoints.
  • Renames ReponseParserError to OsrmParserError. I'd be interested in better naming here, but given some of the error naming TODOs, figured we might want to strategize more globally where we're going with an error system. Especially how tidily rust handles error translation.

@Archdoog Archdoog marked this pull request as ready for review August 6, 2024 03:39
@ianthetechie ianthetechie merged commit 2648bda into main Aug 13, 2024
14 checks passed
@ianthetechie ianthetechie deleted the feat/route-from-osrm branch August 13, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants