-
Notifications
You must be signed in to change notification settings - Fork 713
feat: enforce ordering of allowance check #6602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enforce ordering of allowance check #6602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as CI passes. Thanks!
|
It took me an embarrassing amount of time to figure out what was happening in this PR. I was confused, got a tea, reread and went "oh....Caffeine has made it clear." LGTM! |
1c7bf30
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (66.49%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6602 +/- ##
============================================
- Coverage 79.96% 66.49% -13.47%
============================================
Files 571 571
Lines 351591 351623 +32
============================================
- Hits 281135 233805 -47330
- Misses 70456 117818 +47362
... and 340 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
@jcnelson pointed out that the SIP states that the allowances are checked in declaration order, but my original implementation was only preserving order within each kind of asset movement, not overall. This fixes that.