Skip to content

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Oct 14, 2025

@jcnelson pointed out that the SIP states that the allowances are checked in declaration order, but my original implementation was only preserving order within each kind of asset movement, not overall. This fixes that.

@obycode obycode requested review from a team as code owners October 14, 2025 19:02
@obycode obycode requested a review from jcnelson October 14, 2025 19:02
jcnelson
jcnelson previously approved these changes Oct 14, 2025
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI passes. Thanks!

@jcnelson jcnelson self-requested a review October 14, 2025 21:26
jcnelson
jcnelson previously approved these changes Oct 14, 2025
@jferrant
Copy link
Contributor

It took me an embarrassing amount of time to figure out what was happening in this PR. I was confused, got a tea, reread and went "oh....Caffeine has made it clear."

LGTM!

@brice-stacks brice-stacks added this pull request to the merge queue Oct 22, 2025
Merged via the queue into stacks-network:develop with commit 1c7bf30 Oct 22, 2025
303 of 307 checks passed
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 76.81159% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.49%. Comparing base (7762d88) to head (4fb73a0).
⚠️ Report is 52 commits behind head on develop.

Files with missing lines Patch % Lines
clarity/src/vm/tests/post_conditions.rs 50.00% 16 Missing ⚠️

❌ Your project status has failed because the head coverage (66.49%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (7762d88) and HEAD (4fb73a0). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (7762d88) HEAD (4fb73a0)
140 134
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6602       +/-   ##
============================================
- Coverage    79.96%   66.49%   -13.47%     
============================================
  Files          571      571               
  Lines       351591   351623       +32     
============================================
- Hits        281135   233805    -47330     
- Misses       70456   117818    +47362     
Files with missing lines Coverage Δ
clarity/src/vm/functions/post_conditions.rs 89.68% <100.00%> (+8.12%) ⬆️
clarity/src/vm/tests/post_conditions.rs 64.18% <50.00%> (-35.82%) ⬇️

... and 340 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7762d88...4fb73a0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants