Skip to content

Conversation

@Jiloc
Copy link
Contributor

@Jiloc Jiloc commented Sep 24, 2025

Description

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@Jiloc Jiloc added this to the 3.2.0.0.2 milestone Sep 24, 2025
@Jiloc Jiloc self-assigned this Sep 24, 2025
@Jiloc Jiloc moved this to Status: In Review in Stacks Core Eng Sep 24, 2025
@Jiloc Jiloc linked an issue Sep 24, 2025 that may be closed by this pull request
@Jiloc Jiloc marked this pull request as ready for review September 24, 2025 10:06
@Jiloc Jiloc requested review from a team as code owners September 24, 2025 10:06
@Jiloc Jiloc mentioned this pull request Sep 24, 2025
5 tasks
@Jiloc Jiloc added this pull request to the merge queue Sep 25, 2025
Merged via the queue into stacks-network:develop with commit 895537e Sep 25, 2025
1 of 2 checks passed
@Jiloc Jiloc deleted the chore/move-stackslib-cli-to-stacks-inspect branch September 25, 2025 10:06
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Sep 25, 2025
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 6.66667% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.76%. Comparing base (5934517) to head (848e429).
⚠️ Report is 29 commits behind head on develop.

Files with missing lines Patch % Lines
contrib/stacks-inspect/src/lib.rs 2.77% 35 Missing ⚠️
contrib/stacks-inspect/src/main.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6532      +/-   ##
===========================================
+ Coverage    75.36%   79.76%   +4.39%     
===========================================
  Files          565      565              
  Lines       345043   345052       +9     
===========================================
+ Hits        260037   275224   +15187     
+ Misses       85006    69828   -15178     
Files with missing lines Coverage Δ
stacks-node/src/tests/neon_integrations.rs 54.52% <100.00%> (+0.56%) ⬆️
stackslib/src/chainstate/nakamoto/mod.rs 82.38% <100.00%> (+1.13%) ⬆️
stackslib/src/lib.rs 100.00% <ø> (ø)
contrib/stacks-inspect/src/main.rs 0.00% <0.00%> (ø)
contrib/stacks-inspect/src/lib.rs 19.80% <2.77%> (ø)

... and 258 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5934517...848e429. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked label Oct 3, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[chore] move helper binaries to contrib folder

3 participants