feat: make miner retry when signature collection times out #4926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jferrant
approved these changes
Jun 28, 2024
jcnelson
approved these changes
Jun 28, 2024
|
Hmm... why didn't the CI run for this PR? @wileyj, any thoughts? |
|
oh, never mind. It's a GitHub problem https://www.githubstatus.com |
|
Once one of the other PRs merge, I'll merge develop into this to trigger the CI to run, now that Actions are working again. |
|
sounds good!
…On Fri, Jun 28, 2024 at 1:51 PM Brice Dobry ***@***.***> wrote:
Once one of the other PRs merge, I'll merge develop into this to trigger
the CI to run, now that Actions are working again.
—
Reply to this email directly, view it on GitHub
<#4926 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFCG7QZLHHXWTPXKJVQEYITZJXEFHAVCNFSM6AAAAABKCJXMIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJXGY2DEMJZGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a miner times out when waiting for signatures, it should not end its tenure. Instead it should just retry.