Feat: push blocks to signer set and add /v3/blocks/upload/
#4902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add /v3/blocks/upload, and relayer handling for it * push blocks from miner to signer set, signer set pushes to their stacks-node * configure the signer set test to rely on signers to push the block (by disabling p2p block push)
kantai
force-pushed
the
feat/push-blocks-signers
branch
from
7e51ec3
to
4f0f716
Compare
jcnelson
reviewed
Jun 26, 2024
jcnelson
previously approved these changes
Jun 28, 2024
auto-merge was automatically disabled
June 28, 2024 17:24
Pull Request is not mergeable
obycode
previously approved these changes
Jun 28, 2024
jcnelson
previously approved these changes
Jul 1, 2024
jbencin
reviewed
Jul 2, 2024
jbencin
reviewed
Jul 2, 2024
jbencin
reviewed
Jul 2, 2024
jbencin
previously approved these changes
Jul 2, 2024
jbencin
approved these changes
Jul 2, 2024
jcnelson
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
There should be more test coverage of
/v3/blocks/upload, I think, but I wanted to open this PR quickly to get @jcnelson's quick impression of the/v3/blocks/uploadimplementation, because I don't want that to get in the way of any work he's been doing that may be related (or identical).