chore: Apply new lints in Clippy 1.78 #4780
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbencin in the interest of prioritizing nakamoto work - can we put this in draft, or even delete (for now) and create an issue to track this after 3.0 is done? working on this now could be time-consuming due to the amount of changes, and would most likely cause a lot of issues downstream with other PR's. |
|
@wileyj It's not high priority, you can ignore it for now, I just had some time to kill today while waiting on other things. But it's not a big PR and I can't imagine it would mess anything up |
|
understood. I'm just anticipating downstream conflicts that would require
some refactoring. let's pick this up after 3.0
…On Fri, May 10, 2024 at 16:54 Jeff Bencin ***@***.***> wrote:
@wileyj <https://github.com/wileyj> It's not high priority, you can
ignore it for now, I just had some time to kill today while waiting on
other things. But it's not a big PR and I can't imagine it would mess
anything up
—
Reply to this email directly, view it on GitHub
<#4780 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVXIHAZDMQH6AZKUBS5IYTZBVM4VAVCNFSM6AAAAABHRIO6QSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGM4TCMBQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply lints introduced in recent Clippy release (1.78) to this repository. See Clippy changelog for lints that were introduced