Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] 4746 - Avoid extraneous CI runs (master) #4766

Merged
merged 2 commits into from
May 9, 2024

Conversation

wileyj
Copy link
Contributor

@wileyj wileyj commented May 8, 2024

Small change to the ci workflow to reduce the frequency of when CI is triggered.
previously, various workflows would trigger:

  • open a PR
  • new commits to a PR
  • PR approvals
  • add PR to merge group
  • would not trigger if only change is yml/md

This change does the following:

  • workflow triggers when a PR:
    • is opened
    • is changed
    • only updated files are md/yml (this will be addressed in a future PR - today the required status checks would make this problematic)
  • workflow no longer runs:
    • when PR is approved

@wileyj wileyj requested a review from a team May 8, 2024 16:40
@wileyj wileyj self-assigned this May 8, 2024
@wileyj wileyj added the CI label May 8, 2024
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moment of truth - will it run when I approve?

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me!

@wileyj wileyj merged commit b7f7295 into master May 9, 2024
1 check passed
@wileyj wileyj deleted the fix/reduce_ci_runs-master branch May 9, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants