Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] 4746 - Avoid extraneous CI runs (develop) #4765

Merged
merged 3 commits into from
May 9, 2024

Conversation

wileyj
Copy link
Contributor

@wileyj wileyj commented May 8, 2024

Small change to the ci workflow to reduce the frequency of when CI is triggered.
previously, various workflows would trigger:

  • open a PR
  • new commits to a PR
  • PR approvals
  • add PR to merge group
  • would not trigger if only change is yml/md

This change does the following:

  • workflow triggers when a PR:
    • is opened
    • is changed
    • only updated files are md/yml (this will be addressed in a future PR - today the required status checks would make this problematic)
  • workflow no longer runs:
    • when PR is approved

@wileyj wileyj requested a review from a team May 8, 2024 16:40
@wileyj wileyj self-assigned this May 8, 2024
@wileyj wileyj added the CI label May 8, 2024
@wileyj wileyj closed this May 8, 2024
@wileyj wileyj reopened this May 8, 2024
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wileyj wileyj requested a review from a team May 9, 2024 14:49
@wileyj wileyj added this pull request to the merge queue May 9, 2024
Merged via the queue into develop with commit e8e3a2e May 9, 2024
1 of 2 checks passed
@wileyj wileyj deleted the fix/reduce_ci_runs-develop branch May 9, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants