-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/4734 #4750
Conversation
…om connection_opts.inv_reward_cycles
…ures that a block's hash will depend on the (number of) opts it contains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me -- do the changes in the test code assert that this behavior changed? Can you add a comment to the test if they have?
Added a unit test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This fixes #4734 by ensuring that all inventory synchronizations happen starting from the reward cycle that is
connection_opts.inv_reward_cycles
ago, instead of 0.