Bugfix: verify block transactions only when the upcoming signers appr…

[jferrant]

I just noticed this while explaining an issue to Alin. Signers should be checking the UPCOMING signers aggregate key not their own when determining if they need to include a transaction set.

Closes #4641

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.74%. Comparing base (d54b67c) to head (7f96d08).

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #4640      +/-   ##
==========================================
- Coverage   83.31%   77.74%   -5.58%     
==========================================
  Files         470      470              
  Lines      332768   332772       +4     
  Branches      317      317              
==========================================
- Hits       277247   258707   -18540     
- Misses      55513    74057   +18544     
  Partials        8        8              

Files	Coverage Δ
stacks-signer/src/signer.rs	76.96% <100.00%> (+3.40%)	⬆️

... and 193 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54b67c...7f96d08. Read the comment docs.

[hstove]

This makes sense. I think an argument could be made that this check should be done for the current cycle, too, in 2.5. But I think we should add this as-is

[jferrant]

This makes sense. I think an argument could be made that this check should be done for the current cycle, too, in 2.5. But I think we should add this as-is

There is no point. You will never sign blocks in 2.5