-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: start of ability for miner to keep track of active signers bitvec #4627
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4627 +/- ##
==========================================
- Coverage 83.15% 81.27% -1.89%
==========================================
Files 470 465 -5
Lines 332698 331526 -1172
Branches 317 0 -317
==========================================
- Hits 276663 269444 -7219
- Misses 56027 62082 +6055
+ Partials 8 0 -8
... and 79 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Updated to add an error log based on a comment from Jude in d26e5a6. Requesting re-reviews |
FYI - I fixed an issue with how the block was formed by the miner, which was breaking integration tests. I've also opened #4669 , which is the same code but off of develop. I'm happy to close this, but wanted to double check if that's the right move. |
d921177
to
7d7b270
Compare
This PR is now based off of develop. Would love re-reviews please 😄 |
This PR adds two things:
next_signer_bitvec
property is added. After a miner has collected all block responses from the signers, it updates this BitVec to match the signers who gave a response.Note that, from a functional perspective, all this changes is that the length of the BitVec will match the signer's length. However, the BitVec will be all 1's, even if not all signers respond. Future work is required to construct a new block in the case that a block is rejected, and in that work we can use this
next_signer_bitvec
in that new block.signer_bitvec
based on who signed each block #4558