Add CODEOWNERS #4544
Add CODEOWNERS #4544
Conversation
wileyj
added
enhancement
|
for now, keeping user id's is fine - but i'm also thinking that some new teams in the org would be be easier to manage longer-term. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4544 +/- ##
==========================================
+ Coverage 83.35% 83.46% +0.11%
==========================================
Files 453 471 +18
Lines 328034 337957 +9923
Branches 323 317 -6
==========================================
+ Hits 273431 282076 +8645
- Misses 54595 55873 +1278
Partials 8 8 see 131 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
I have no problem with it :) |
|
thanks! once i setup appropriate teams i'll adjust the file. |
* next: (282 commits) Bugfix: verify block transactions only when the upcoming signers approved key is not set Fix bad merge 2 Fix bad merge CRC: change debug to info for pre epoch 3.0 cycles requiring a fee Add unit tests for is_in_prepare_phase and is_in_reward_cycle functions CRC: remove duplicate logging Reward cycle length was being incorrectly stored as reward phase length Consider nonce when checking for existing vote transactions in stackerdb during update_dkg Fix bad merge feat: more efficient tuple types, reduce type map tracking overhead CRC: do not pop the command until its executed CRC: add config tests and remove config log CRC: remove dead path and update debug message to a warn Update stacks-signer to attempt to estimate the transaction fee if a user sets max_tx_fee_ustx in the config Seperate unsigned and signed transaction building and update tests Add get_medium_estimated_fee_ustx to get estimated fee from stacks node Remove unnecessary retries throughout code fix: don't log aggregate public keys as missing so often (do so at the caller's option), and in the p2p stack in particular, remember that aggregate public keys are never going to appear if we're pre-3.0 feat: dont pretty-print json output chore: Update "stacks-blockchain" -> "stacks-core" ...
* next: update per 4638 removing portable flag fix: dont warn about aggregate key in 2.5
|
now that 2.5 is out, should this be rebased against develop? |
* develop: (420 commits) remove extra character from vi typo remove paths-ignore 4746 - avoid extra ci runs chore: fix comment typo fix: more PR feedback -- better, more-complete AtcRational tests and better abstraction over the inner u256 chore: address PR feedback and add more test coverage chore: add unit test chore: add unit test feat: add no-op metrics timer when feature disabled chore: get all unit tests to pass chore: API sync chore: add a mode of generating burnchain blocks in TestPeer that ensures that a block's hash will depend on the (number of) opts it contains fix: don't start from reward cycle 0 when doing an inv sync; start from connection_opts.inv_reward_cycles chore: expose set_initial_peer fix: optionally disable resolving bootstrap nodes, so the caller can avoid needless network I/O if it's not needed chore: use the burnchain indexer to find the right block header fix: revert changes in contrib/core-contract-tests/ fix: typos chore: index block-commits by apparent sender, so we can get the last commit by sender fix: generate the expected block commit input so that mining works in nakamoto ...
|
rebased against there are some paths in the repo that i wasn't sure should have a team directly added as a codeowner, but i'm open to adjusting based on any suggestions. |
@jcnelson @kantai @obycode @jferrant @xoloki
could use some help here to iron out any additional paths that should be added .
Once enforced, the idea is to require a codeowner (listed in the file in this PR) to approve a PR before it can merge.
by default, jcnelson/kantai/obycode will be added to all PR's unless specified later in the file (ex: wileyj/charliec3 will be added to PR's changing CI workflows).
what i've added so far is a best guess based on commit history, but i think it can/should be ironed out a bit more before enforcing.
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners