Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect arg index in synthetic event #4332

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Feb 1, 2024

In #4329 (just merged) one of the synthetic events used an incorrect arg index in the print for stack-stx.

I also noticed that stack-aggregation-increase and stack-aggregation-commit have diverged argument signatures - -increase's third arg is reward-cycle-index, whereas -commit's third arg is signer-key. I've made a separate match branch to reflect this change.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74e3ced) 83.39% compared to head (827d4d2) 73.76%.
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4332      +/-   ##
==========================================
- Coverage   83.39%   73.76%   -9.63%     
==========================================
  Files         435      435              
  Lines      309254   309278      +24     
==========================================
- Hits       257892   228136   -29756     
- Misses      51362    81142   +29780     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hstove!

@hstove hstove merged commit 5c14a44 into next Feb 2, 2024
1 of 2 checks passed
@hstove hstove deleted the fix/pox-synthetic-events branch February 2, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants