Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify test_simple_signer to fix intermittent failure #4306

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Jan 29, 2024

#4280 modified a test in libsigner to test the /status endpoint. Because I didn't realize that the test signer thread was configured to exit after 5 events, I designed the test wrongly. Tests would pass locally and sometimes on CI, but I realized later that the tests would sometimes fail in CI because a thread would receive an event before it was shutdown.

This PR:

  • Removes the /status endpoint testing in the original test
  • Adds a new test that's specifically for the status endpoint

@hstove hstove requested a review from jferrant January 29, 2024 23:25
@hstove hstove changed the title fix: modify simple signer test to fix intermittent failure fix: modify test_simple_signer to fix intermittent failure Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (bdb2e3c) 83.38% compared to head (119caa6) 83.27%.

Files Patch % Lines
libsigner/src/tests/mod.rs 90.69% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4306      +/-   ##
==========================================
- Coverage   83.38%   83.27%   -0.12%     
==========================================
  Files         434      434              
  Lines      308770   308799      +29     
==========================================
- Hits       257482   257142     -340     
- Misses      51288    51657     +369     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hstove hstove merged commit 43d8695 into next Jan 30, 2024
2 checks passed
@hstove hstove deleted the fix/signer-test-threading branch January 30, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants