-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miners handle signers block responses from the stacker db instance #4281
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #4281 +/- ##
==========================================
- Coverage 82.83% 82.60% -0.23%
==========================================
Files 442 443 +1
Lines 314970 315904 +934
==========================================
+ Hits 260898 260963 +65
- Misses 54072 54941 +869 ☔ View full report in Codecov by Sentry. |
c531924
to
aa0acd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to get rid of some of the expect calls, but they were already present so not a blocker for this PR
aa0acd7
to
caf7299
Compare
8fe5d80
to
af74765
Compare
9b43720
to
e11994f
Compare
Fixed in #4294 |
1bd4e72
to
55f73de
Compare
3a2c200
to
b526aac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks mostly good to me -- I just have a couple comments about u8 enums, and a request on the changes in the miner thread.
fc8fd19
to
e2a5478
Compare
e2a5478
to
2aa3528
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question about whether or not rejection thresholds should be configurable, but otherwise LGTM.
Before merging, please implement extension traits for wsts
types and then implement StacksMessageCodec
for those.
2aa3528
to
29301d6
Compare
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…types Signed-off-by: Jacinta Ferrant <[email protected]>
…st into the same function Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
2b33d4f
to
20f2e0e
Compare
Description
This is the first stab at miners handling stacker db events from the signers. Progress beyond this point is blocked by the .signers pox 4 contract combined with the ability for signers to broadcast their aggregate keys.
Applicable issues
Additional info (benefits, drawbacks, caveats)
A more complete solution would directly use the event observer trait (avoiding the use of the http server), but for an initial attempt, I just directly access the stacker db instance of the miner. As I am semi blocked, I might try making this change now. However review would be good anyway as this logic will not change much.
Next steps would be to actually append the block when we have .signers / aggregate key correctly set