Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wsts version to 6.0 and use Packet::verify function #4227

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

jferrant
Copy link
Collaborator

@jferrant jferrant commented Jan 3, 2024

Description

Need the newest wsts version changes for handling <100% participation in DKG
Also required for processing coordinator messages while in the IDLE state which enables DKG to be calculated by all signers simultaneously

Applicable issues

Copy link
Collaborator

@xoloki xoloki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm as long as CI (test_stackerdb_dkg specifically) passes

@stacks-network stacks-network deleted a comment from codecov bot Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (f98656c) 82.89% compared to head (0cfebe3) 82.92%.

Files Patch % Lines
stacks-signer/src/runloop.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4227      +/-   ##
==========================================
+ Coverage   82.89%   82.92%   +0.03%     
==========================================
  Files         429      429              
  Lines      302932   302864      -68     
==========================================
+ Hits       251109   251154      +45     
+ Misses      51823    51710     -113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcnelson
Copy link
Member

jcnelson commented Jan 3, 2024

I don't think the stackerdb tests are running here?

@xoloki
Copy link
Collaborator

xoloki commented Jan 4, 2024

@jferrant I changed the PR description to specify that this does not close #4111, but it is a part of it. I don't think we should close #4111 until I do that last piece of robustness, i.e. allow partial DkgPrivateShares participation as long as a DKG threshold subset of the DkgPublicShares responders also send DkgPrivateShares. Current wsts 6.0.0 allows partial DkgPublicShares, but then requires that they all send DkgEnd or DKG fails.

@xoloki
Copy link
Collaborator

xoloki commented Jan 4, 2024

I don't think the stackerdb tests are running here?

I ran test_stackerdb_dkg locally, and it passed. But yeah I don't see an explicit CI action that calls it @jcnelson

@xoloki
Copy link
Collaborator

xoloki commented Jan 4, 2024

Ok @jcnelson it looks like test_stackerdb_dkg and the other StackerDB tests are part of sbtc-tests.yml, not bitcoin-tests.yml, and they aren't running currently. @wileyj is there some reason the sBTC/StackerDB tests aren't running currently? I know they take a while, but are they flakey in CI?

@jferrant jferrant merged commit 3e21883 into next Jan 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants