-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mempool admission for Nakamoto Blocks #4149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- just some small feedback.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #4149 +/- ##
==========================================
+ Coverage 21.11% 21.37% +0.26%
==========================================
Files 418 418
Lines 295286 295286
==========================================
+ Hits 62338 63107 +769
+ Misses 232948 232179 -769 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this! Requesting that you simply delete the code that gets the staging block height, because PoisonMicroblock
transactions and queries against unconfirmed microblocks simply don't exist in Nakamoto.
95926ec
to
f867686
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3ef11cb
to
168c2b3
Compare
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
168c2b3
to
d28e4e9
Compare
Changes
- added get_nakamoto_block_height to check against nakamoto_staging_blocks in chainstate- first attempt to check against nakamoto before checking against regular stacks when retrieving the block height in admission checkFixes #4148