Feat: Mockamoto + coordinator integration #4098
Conversation
testnet/stacks-node/src/mockamoto.rs
Outdated
| let vrf_seed = VRFSeed::from_proof(&parent_vrf_proof); | ||
|
|
||
| let block_commit = LeaderBlockCommitOp { | ||
| block_header_hash: BlockHeaderHash([0; 32]), |
There was a problem hiding this comment.
Pretty sure this field is getting validated now. This should be the index block hash of the last tenure's tenure-start block.
There was a problem hiding this comment.
I updated this to be the parent block ID, but I would suggest that this is not being validated currently: the coordinator absolutely accepted blocks with null block header hashes.
There was a problem hiding this comment.
the coordinator absolutely accepted blocks with null block header hashes.
Oh interesting! I'll see if I can fix this in my tenure-change validation PR.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #4098 +/- ##
==========================================
- Coverage 0.04% 0.04% -0.01%
==========================================
Files 419 421 +2
Lines 297652 298557 +905
==========================================
Hits 136 136
- Misses 297516 298421 +905 ☔ View full report in Codecov by Sentry. |
jferrant
force-pushed
the
feat/mockamoto-mining-redux
branch
from
05274b6
to
b447984
Compare
There was a problem hiding this comment.
@kantai events for the initial boot contracts and seed balance are missing:
- The initial synthetic
token_transfertx containingstx_mintevents for the seed account(s) - These contracts:
bns,pox,costs,cost-voting,genesis.
The API tests don't work very well when the stx_mints and bns boot contract in particular are missing. Anyway to get these working?
…nlock to /new_block events
|
@zone117x -- both should be added in my last commit. |
Description
This PR integrates the mockamoto node into the latest nakamoto coordinator work. It includes a test case that ensures that the event observer sees 100 nakamoto blocks.
This operation simulates bitcoin blocks, storing them directly into the burndb, and then notifying the chains coordinator.