Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix developer mode issue #3978

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Fix developer mode issue #3978

merged 2 commits into from
Sep 22, 2023

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Sep 22, 2023

Description

This is a follow up to #3955. I previously missed the fact that stackslib enabled developer-mode in the default feature set. This should not be the case.

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@obycode
fix: disable developer-mode by default in stackslib
331c339 
This should not be enabled by default. Tools that want to use
developer-mode should do so explicitly. Building a stacks-node should,
by default, NOT use developer-mode.
@obycode obycode changed the base branch from master to develop September 22, 2023 13:43
@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Merging #3978 (d5c5ecc) into develop (904c7ab) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop    #3978     +/-   ##
==========================================
  Coverage     0.16%    0.16%             
==========================================
  Files          339      339             
  Lines       290230   287624   -2606     
==========================================
  Hits           469      469             
+ Misses      289761   287155   -2606

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This was referenced Sep 22, 2023
Merged
Closed
wileyj
wileyj approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@wileyj wileyj merged commit d9a4f8d into develop Sep 22, 2023
2 checks passed
@wileyj wileyj deleted the fix/clarity-developer-mode branch September 22, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcnelson jcnelson jcnelson approved these changes

@wileyj wileyj wileyj approved these changes

@jferrant jferrant jferrant approved these changes

@EmbeddedAndroid EmbeddedAndroid Awaiting requested review from EmbeddedAndroid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stacks panics with 'Failed to deserialize vm.Value: Error("missing field pre_comments")'
4 participants
@obycode @jcnelson @wileyj @jferrant