Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lower warning about mempool nonce caching to debug! #3964

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Sep 21, 2023

Description

The warning about failing to cache mempool nonces shows up very often during normal execution of the node. It should not be a warning. This PR lowers it to a debug message.

error caching nonce to sqlite: database is locked

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

This case happens often in normal execution, so it is just spamming the
logs as a `warn!`.
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #3964 (fb36ff3) into master (e4630ec) will decrease coverage by 58.26%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master    #3964       +/-   ##
===========================================
- Coverage   58.31%    0.06%   -58.26%     
===========================================
  Files           1      300      +299     
  Lines         571   276551   +275980     
===========================================
- Hits          333      179      -154     
- Misses        238   276372   +276134     
Files Changed Coverage Δ
src/core/mempool.rs 0.00% <0.00%> (ø)

... and 300 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the logged error in this case?

@obycode
Copy link
Contributor Author

obycode commented Sep 22, 2023

What was the logged error in this case?

I'm not sure what you're asking. It was just the above mentioned: error caching nonce to sqlite: database is locked.

@jcnelson
Copy link
Member

Ah, I missed that 🤦 I just went straight to the code

@jcnelson jcnelson merged commit 11e6439 into master Sep 29, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants