Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update libraries #3758

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Chore/update libraries #3758

merged 5 commits into from
Jun 27, 2023

Conversation

pavitthrap
Copy link
Contributor

Description

  • updates the version of warp
  • fixes multiple warnings
  • adds a debug log in the case a PoX anchor block isn't chosen

Applicable issues

@pavitthrap pavitthrap changed the title Chore/update lib Chore/update libraries Jun 13, 2023
@pavitthrap pavitthrap requested review from fpbgg and wileyj June 13, 2023 20:38
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #3758 (38c75e3) into develop (7a0e572) will decrease coverage by 0.82%.
The diff coverage is 92.85%.

@@             Coverage Diff             @@
##           develop    #3758      +/-   ##
===========================================
- Coverage    85.79%   84.97%   -0.82%     
===========================================
  Files          302      302              
  Lines       286529   286538       +9     
===========================================
- Hits        245830   243490    -2340     
- Misses       40699    43048    +2349     
Impacted Files Coverage Δ
src/chainstate/coordinator/mod.rs 87.18% <50.00%> (+1.82%) ⬆️
testnet/stacks-node/src/tests/epoch_22.rs 96.53% <100.00%> (+0.35%) ⬆️
testnet/stacks-node/src/tests/epoch_23.rs 99.63% <100.00%> (+<0.01%) ⬆️
testnet/stacks-node/src/tests/epoch_24.rs 98.18% <100.00%> (ø)
testnet/stacks-node/src/tests/neon_integrations.rs 82.43% <100.00%> (-0.95%) ⬇️

... and 42 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wileyj wileyj requested a review from kantai June 20, 2023 15:16
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@wileyj wileyj merged commit 6ba3f2f into develop Jun 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants