Refactor u32::max_value() with u32::MAX
#3735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## develop #3735 +/- ##
===========================================
- Coverage 85.08% 82.90% -2.18%
===========================================
Files 298 302 +4
Lines 276674 286537 +9863
===========================================
+ Hits 235397 237543 +2146
- Misses 41277 48994 +7717
... and 33 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pavitthrap
approved these changes
Jun 5, 2023
CHANGELOG.md
Outdated
| @@ -21,6 +21,12 @@ and this project adheres to the versioning scheme outlined in the [README.md](RE | |||
| runtime error and include details about the error in the `vm_error` field of | |||
| the receipt. Fixes issues #3154, #3328. | |||
|
|
|||
| ### Changed | |||
|
|
|||
| - All occurrences of the deprecated method `u32::max_value()` (as well as `u64` | |||
There was a problem hiding this comment.
This isn't the type of change that needs to be recorded in the changelog in my opinion (nothing is changing externally).
There was a problem hiding this comment.
Yeah, I agree. I will remove that entirely.
pavitthrap
merged commit 4c0182a
into
stacks-network:chore/merge-u32-max
1 of 2 checks passed
|
Congrats @Acaccia on your first merged Stacks blockchain PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I changed all occurrences of deprecated
u32::max_value().While I was at it, I changed the same deprecated method for
u64andi32hiding there.Applicable issues
u32::max_value()withu32::MAX#3682Additional info (benefits, drawbacks, caveats)
Checklist