Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/Build: Speedup unit tests #3632

Merged
merged 2 commits into from
Mar 30, 2023
Merged

CI/Build: Speedup unit tests #3632

merged 2 commits into from
Mar 30, 2023

Conversation

kantai
Copy link
Member

@kantai kantai commented Mar 23, 2023

Description

Our unit-test task in CI currently takes ~2 hours to run. This impacts the time-from-approval to time-of-merge for PRs. I think there's a couple potential quick wins here:

  1. Use opt-level=3 for package dependencies in dev profiles. This shouldn't impact developer compiler times substantially, because those packages should only be rebuilt quite rarely. However, these can speed up the performance of tests.
  2. Replace the dockerized unit test with raw GH workflow run commands.

I'm keeping this as a draft because I want to see how the CI actually responds to these changes.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #3632 (136220e) into develop (3c6d177) will increase coverage by 56.25%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #3632       +/-   ##
============================================
+ Coverage    28.68%   84.93%   +56.25%     
============================================
  Files          298      298               
  Lines       276611   276611               
============================================
+ Hits         79345   234941   +155596     
+ Misses      197266    41670   -155596     

see 269 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kantai
Copy link
Member Author

kantai commented Mar 23, 2023

Looks like 4cd8ef0 shaved ~30 minutes off of the unit-tests runtime. Will try out the raw Github actions next.

@kantai kantai changed the title Draft: Attempt to speedup unit tests in CI CI/Build: Speedup unit tests Mar 27, 2023
Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small conflict in 3199, since the file location of when this test runs is different.
copypaste should be enough for the few changed lines in ci.yml

@pavitthrap pavitthrap merged commit 0e026ba into develop Mar 30, 2023
@kantai kantai deleted the chore/unit-test-speedup branch March 30, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants