Rewrite of tuple consensus-buff deserialization #434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of completing #307 .
This PR rewrites completely the tuple deserialization function to allow for the missing functionalities.
For now, the missing functionalities implemented are
To satisfy those conditions, the new algorithm in pseudo-code became
These contains new functionalities that had to be created:
i32
locals, the logic to handle it is directly inside the deserialization algo.br_table
instruction to jump after the block labelled like the currently parsed field (I suggest compiling a few examples to see what it looks like).TODO
for now but is nearly complete already. I decided to cut it from this PR and add it in a future one because it will require quite a lot of code to handle the testing.