-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate code from stacks-core to clar2wasm #367
Conversation
@krl which commit of stacks-core is the code taken from? |
@Acaccia latest feat/clarity-wasm-next |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
- Coverage 91.14% 87.15% -4.00%
==========================================
Files 40 43 +3
Lines 14063 18510 +4447
Branches 14063 18510 +4447
==========================================
+ Hits 12818 16132 +3314
- Misses 573 1048 +475
- Partials 672 1330 +658 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I got, code that was on stacks-core
was pushed to clarity-wasm
repo and split into initialize
, wasm_utils
and linker
files.
With that change, initialize
is now the orchestrator when dealing with Clarity contracts initialization and execution on wasm.
All set os tests are running ok (only one regression already noted).
Code LGTM! Approved. But would be great to also have another pair of eyes on those changes. /cc @Acaccia
Good work @krl ! Thanks!
This PR moves most code related to wasm to the clar2wasm repo.
It seems like where the code should be in the first place, and will make developing changes and tests much less painful.
Draft for now since i need to update the paths to use branches instead of hard-coded paths. This was done to make sure the stacks-core side is still working. A pr in that repo removing the code is coming as well soon.