Fix issue #356 #366
Merged
Fix issue #356 #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
=======================================
Coverage 91.21% 91.21%
=======================================
Files 40 40
Lines 14015 14015
Branches 14015 14015
=======================================
Hits 12784 12784
Misses 567 567
Partials 664 664 ☔ View full report in Codecov by Sentry. |
csgui
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
LGTM!
1: checked the implementation that seems ok:
i64.gt_u results in a i32.
i64.ne also results in a i32.
Both are used as arguments to the binary i32.or operation that expects two 32-bits.
2: validated and checked test cases looking for edge and valid values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #356
$stdlib.pow-intomitted to check for the second operand higher part in its overflow check.