Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make go binaries executable #1155

Merged
merged 1 commit into from
Apr 22, 2022
Merged

make go binaries executable #1155

merged 1 commit into from
Apr 22, 2022

Conversation

stehessel
Copy link
Collaborator

Lima manages virtual machines on macOS, which can be used as a
replacement to Docker Desktop. Currently, Lima contains a bug that
leads to go binaries not being executable if they have been built inside
a mounted volume (lima-vm/lima#602).

As a workaround, add execution to the file permissions explicitly. This
should be a no-op when Lima is not used, for example on Linux systems.

@stehessel stehessel force-pushed the stehessel/lima-fix branch from 4c5850b to c7d6edf Compare April 21, 2022 20:29
@stehessel stehessel requested a review from a team April 21, 2022 20:32
@ghost
Copy link

ghost commented Apr 21, 2022

Tag for build #459579 is 3.69.x-459-gaa8f3de4df.

💻 For deploying this image using the dev scripts, run the following first:

export MAIN_IMAGE_TAG='3.69.x-459-gaa8f3de4df'

🕹️ A roxctl binary can be downloaded from the CircleCI artifacts.

Lima manages virtual machines on macOS, which can be used as a
replacement to `Docker Desktop`. Currently, Lima contains a bug that
leads to go binaries not being executable if they have been built inside
a mounted volume (lima-vm/lima#602).

As a workaround, add execution to the file permissions explicitly. This
should be a no-op when Lima is not used, for example on Linux systems.
@stehessel stehessel force-pushed the stehessel/lima-fix branch from 408d9a2 to aa8f3de Compare April 21, 2022 23:12
@stehessel stehessel merged commit b2c02a3 into master Apr 22, 2022
@stehessel stehessel deleted the stehessel/lima-fix branch April 22, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants