Skip to content

Conversation

@ChrisJBurns
Copy link
Collaborator

@ChrisJBurns ChrisJBurns commented Nov 21, 2025

Removes all sync code (automatic and manual) from the Operator. I tried to keep the manual sync but it was taking a bit too long to refactor and keep tests passing. For this reason, I've taken the entirety of the sync code. When we add multiple data sources, we have to rethink the sync code anyways and it makes sense to start from a fresh slate in this way. We can always ref to the old sync implementation if we need a reference/inspiration.

This PR is over 2k changes mainly because its removing of an entire capability. Trying to remove bits at a time resulted in more time due to fixing broken tests etc. It was easier to just remove them completely.

Signed-off-by: Chris Burns <[email protected]>
Signed-off-by: Chris Burns <[email protected]>
@ChrisJBurns ChrisJBurns changed the title Removes auto sync operator Removes sync operator Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.50%. Comparing base (192c971) to head (6babb7d).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...thv-operator/controllers/mcpregistry_controller.go 0.00% 27 Missing ⚠️
cmd/thv-operator/pkg/mcpregistrystatus/deriver.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2682      +/-   ##
==========================================
+ Coverage   55.29%   55.50%   +0.20%     
==========================================
  Files         315      312       -3     
  Lines       30299    30035     -264     
==========================================
- Hits        16754    16670      -84     
+ Misses      12076    11897     -179     
+ Partials     1469     1468       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisJBurns ChrisJBurns marked this pull request as ready for review November 21, 2025 18:17
@ChrisJBurns ChrisJBurns changed the title Removes sync operator removes sync capability from operator Nov 21, 2025
@ChrisJBurns ChrisJBurns enabled auto-merge (squash) November 21, 2025 19:20
@ChrisJBurns ChrisJBurns merged commit 17f65eb into main Nov 22, 2025
31 checks passed
@ChrisJBurns ChrisJBurns deleted the removes-auto-sync-operator branch November 22, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants