Persist claims on registry upsert conflict#746
Merged
Conversation
The `UpsertRegistry` SQL query only updated `updated_at` on conflict,
silently dropping any new `claims` value. This meant that editing a
registry via `PUT /v1/registries/{name}` would appear to succeed (the
timestamp advanced) but the claims column kept its original value.
Add `claims = EXCLUDED.claims` to the `ON CONFLICT DO UPDATE SET`
clause and regenerate the sqlc code. A new regression test
(`TestUpsertRegistryUpdatesClaims`) pins both the value-update and
clear-to-nil paths.
rdimitrov
approved these changes
Apr 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #746 +/- ##
=======================================
Coverage 60.64% 60.64%
=======================================
Files 108 108
Lines 10482 10482
=======================================
Hits 6357 6357
Misses 3572 3572
Partials 553 553 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
UpsertRegistrySQL query only updatedupdated_aton conflict, silently dropping any newclaimsvalue. This meant that editing a registry viaPUT /v1/registries/{name}would appear to succeed (the timestamp advanced) but the claims column kept its original value.Add
claims = EXCLUDED.claimsto theON CONFLICT DO UPDATE SETclause and regenerate the sqlc code. A new regression test (TestUpsertRegistryUpdatesClaims) pins both the value-update and clear-to-nil paths.