Skip to content

Fix: ConfigureRegion() throws error if the region is set by environment variable #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Fix: ConfigureRegion() throws error if the region is set by environment variable #1262

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3990cdc
Fix: ConfigureRegion() throws error if the region is set by environme…
marceljk Jan 8, 2025
5e7d401
Add changelog
marceljk Jan 8, 2025
5b4698b
Add changes to CHANGELOG in root
marceljk Jan 8, 2025
baa4e77
Update changelog release date
marceljk Jan 8, 2025
86e9a56
Fix: Changelog format update
marceljk Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,10 +499,12 @@ func ConfigureRegion(cfg *Configuration) error {
availableRegions = append(availableRegions, strings.TrimSuffix(regionWithDotSuffix, "."))
}

isRegionSetByEnv := false
if cfg.Region == "" {
// Check region
envVarRegion, _ := os.LookupEnv("STACKIT_REGION")
cfg.Region = envVarRegion
isRegionSetByEnv = true
}

if oasRegion.DefaultValue != "" && oasRegion.DefaultValue != global {
Expand All @@ -524,9 +526,9 @@ func ConfigureRegion(cfg *Configuration) error {
return fmt.Errorf("the provided region is not available for this API, available regions are: %s", availableRegions)
}
// Global API.
// If a region is provided by the user via WithRegion() or via environment variable return an error.
// If a region is provided by the user via WithRegion() return an error.
// The region is provided as a function argument instead of being set in the client configuration.
if cfg.Region != "" {
if cfg.Region != "" && !isRegionSetByEnv {
return fmt.Errorf("this API does not support setting a region in the the client configuration, please check if the region can be specified as a function parameter")
}
// If the url is a template, generated using deprecated config.json, the region variable is replaced
Expand Down
Loading